git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: What's cooking in git.git (Mar 2019, #04; Wed, 20)

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 21, 2019, 00:31 UTC
Message-ID
<xmqqmulpukyf.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20190320225638.GF32487@hank.intra.tgummerer.com>
Thomas Gummerer <t.gummerer@gmail.com> writes:
Show 26 quoted lines
> On 03/21, Rohit Ashiwal wrote:
>> Hey Junio!
>> 
>> On Wed, 20 Mar 2019 12:13:47 +0900 Junio C Hamano <gitster@pobox.com> wrote:
>> > * ra/t3600-test-path-funcs (2019-03-08) 3 commits
>> >  - t3600: use helpers to replace test -d/f/e/s <path>
>> >  - t3600: modernize style
>> >  - test functions: add function `test_file_not_empty`
>> >
>> >  A GSoC micro.
>> >
>> >  Will merge to 'next'.
>> >  cf. <20190304120801.28763-1-rohit.ashiwal265@gmail.com> (v3)
>> 
>> If we are going to merge these in next revision, I say there are some
>> minor changes that Eric suggested, basically there were some extra spaces
>> in commit messages and a small change in commit message of [PATCH v3 3/3].
>> There will *not* be any change in code. Should I attend to them or we are
>> merging anyway?
>
> Junio sometimes applies these fixes himself, if he deems it easier to
> apply them directly than to wait for another iteration, and if he has
> time to do so.  If you have a look at the ra/t3600-test-path-funcs
> branch in gitster/git, e.g. on GitHub [*1*], you can see that Eric's
> suggestions for the commit message in 3/3 have already been applied,
> so there's nothing more you need to do here at this point.
Thanks.
Previous: Rohit AshiwalNext: Ævar Arnfjörð Bjarmason
Message 7 of 14 in “What's cooking in git.git (Mar 2019, #04; Wed, 20)”
  1. Junio C HamanoMar 20, 2019
  2. Junio C HamanoMar 20, 2019
  3. Thomas GummererMar 20, 2019
  4. Rohit AshiwalMar 20, 2019
  5. Thomas GummererMar 20, 2019
  6. Rohit AshiwalMar 20, 2019
  7. Junio C HamanoMar 21, 2019
  8. Ævar Arnfjörð BjarmasonMar 20, 2019
  9. Junio C HamanoMar 21, 2019
  10. Junio C HamanoMar 21, 2019
  11. Ævar Arnfjörð BjarmasonMar 21, 2019
  12. Junio C HamanoMar 21, 2019
  13. Ævar Arnfjörð BjarmasonMar 21, 2019
  14. Duy NguyenMar 21, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.