Re: What's cooking in git.git (Mar 2019, #04; Wed, 20)

From: Thomas Gummerer <t.gummerer@gmail.com>
Date: Mar 20, 2019, 22:56 UTC
Message-ID: <20190320225638.GF32487@hank.intra.tgummerer.com>
In-Reply-To: <20190320220509.7180-1-rohit.ashiwal265@gmail.com>

On 03/21, Rohit Ashiwal wrote:

Show 18 quoted lines

> Hey Junio!
> 
> On Wed, 20 Mar 2019 12:13:47 +0900 Junio C Hamano <gitster@pobox.com> wrote:
> > * ra/t3600-test-path-funcs (2019-03-08) 3 commits
> >  - t3600: use helpers to replace test -d/f/e/s <path>
> >  - t3600: modernize style
> >  - test functions: add function `test_file_not_empty`
> >
> >  A GSoC micro.
> >
> >  Will merge to 'next'.
> >  cf. <20190304120801.28763-1-rohit.ashiwal265@gmail.com> (v3)
> 
> If we are going to merge these in next revision, I say there are some
> minor changes that Eric suggested, basically there were some extra spaces
> in commit messages and a small change in commit message of [PATCH v3 3/3].
> There will *not* be any change in code. Should I attend to them or we are
> merging anyway?

Junio sometimes applies these fixes himself, if he deems it easier to apply them directly than to wait for another iteration, and if he has time to do so. If you have a look at the ra/t3600-test-path-funcs branch in gitster/git, e.g. on GitHub [*1*], you can see that Eric's suggestions for the commit message in 3/3 have already been applied, so there's nothing more you need to do here at this point.

*1*: https://github.com/gitster/git/tree/ra/t3600-test-path-funcs