Re: [PATCH v2 2/2] diff: batch fetching of missing blobs

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 8, 2019, 05:51 UTC
Message-ID: <xmqqmul19h9j.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <xmqqy34lb4vb.fsf@gitster-ct.c.googlers.com>

Junio C Hamano <gitster@pobox.com> writes:

Show 17 quoted lines

> Christian Couder <christian.couder@gmail.com> writes:
>
>> Thanks for investigating! Yeah, that's part of the problem.
>>
>> The fix I would suggest is:
>>
>> diff --git a/diff.c b/diff.c
>> index f685ab10b5..a2b1241f83 100644
>> --- a/diff.c
>> +++ b/diff.c
>> @@ -26,6 +26,7 @@
>>  #include "parse-options.h"
>>  #include "help.h"
>>  #include "fetch-object.h"
>> +#include "promisor-remote.h"
>
> Thanks.

Together with "if we are forbidding the direct access to the repository_format_partial_clone variable and the fetch_objects() funciton, make it clear that is what is being done in the multi-promisor topic", I think a patch that adds this header should also remove inclusion of "fetch-object.h".