Re: [PATCH v2 2/2] diff: batch fetching of missing blobs

From: Christian Couder <christian.couder@gmail.com>
Date: Apr 8, 2019, 06:45 UTC
Message-ID: <CAP8UFD15V1yskNzPjROCcOvarz34NdwOoSM2JRh3zNJhNeXA=g@mail.gmail.com>
In-Reply-To: <xmqqftqt9gpz.fsf@gitster-ct.c.googlers.com>

On Mon, Apr 8, 2019 at 8:03 AM Junio C Hamano <gitster@pobox.com> wrote:

Show 15 quoted lines

>
> Junio C Hamano <gitster@pobox.com> writes:
>
> >>>  #include "fetch-object.h"
> >>> +#include "promisor-remote.h"
> >>
> >> Thanks.
> >
> > Together with "if we are forbidding the direct access to the
> > repository_format_partial_clone variable and the fetch_objects()
> > funciton, make it clear that is what is being done in the
> > multi-promisor topic", I think a patch that adds this header should
> > also remove inclusion of "fetch-object.h".
>
> In fact, your topic itself has the same issue.

Yeah sorry, this is the kind of things I easily forget.

> I'll queue the
> following at the tip of the topic tentatively before merging it to
> 'pu' with the fix we have been discussing around this thread.

Thanks!