git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4] grep: fail if call could output and name is null

From
Junio C Hamano <gitster@pobox.com>
Date
May 28, 2019, 17:57 UTC
Message-ID
<xmqqmuj631j0.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20190523203415.GB70860@google.com>
Jonathan Nieder <jrnieder@gmail.com> writes:
Show 15 quoted lines
> Emily Shaffer wrote:
>
>> Signed-off-by: Emily Shaffer <emilyshaffer@google.com>
>> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
>> ---
>> Since v3, only the commit message has changed. Reworked based on
>> Jonathan Nieder's suggestions (with some modifications for readability).
>>
>>  grep.c | 4 ++++
>>  1 file changed, 4 insertions(+)
>
> This is indeed
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
>
> Thanks for your patient work.
Thanks, both.  Will queue.
Previous: Jonathan Nieder
Message 15 of 15 in “grep: provide sane default to grep_source struct”
  1. grep: provide sane default to grep_source structEmily Shaffer, May 16, 2019
  2. Junio C HamanoMay 16, 2019
  3. Jonathan NiederMay 16, 2019
  4. Jonathan NiederMay 16, 2019
  5. Emily ShafferMay 16, 2019
  6. grep: provide sane default to grep_source structEmily Shaffer, May 16, 2019
  7. Jeff KingMay 16, 2019
  8. Emily ShafferMay 21, 2019
  9. Jonathan NiederMay 22, 2019
  10. grep: provide sane default to grep_source structEmily Shaffer, May 22, 2019
  11. Jonathan NiederMay 22, 2019
  12. Jeff KingMay 22, 2019
  13. grep: fail if call could output and name is nullEmily Shaffer, May 23, 2019
  14. Jonathan NiederMay 23, 2019
  15. Junio C HamanoMay 28, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.