git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3] grep: provide sane default to grep_source struct

From
Jeff King <peff@peff.net>
Date
May 22, 2019, 04:01 UTC
Message-ID
<20190522040100.GA31212@sigill.intra.peff.net>
In-Reply-To
<20190522003402.77767-1-emilyshaffer@google.com>
On Tue, May 21, 2019 at 05:34:02PM -0700, Emily Shaffer wrote:
Show 6 quoted lines
> I think Peff and Jonathan are right. If someone does want to hack away
> on something in the very early stages, the BUG() line gives a pretty
> clear indicator of what to modify to make it work.
> 
> I also moved the BUG() to grep_source_1() to keep it close to the error
> itself and reflowed the commit message.

Thanks. This version looks good to me (though if you took any of Jonathan's suggestions in the other part of the thread that would be fine with me, too).

-Peff
Previous: Jonathan NiederNext: Emily Shaffer
Message 12 of 15 in “grep: provide sane default to grep_source struct”
  1. grep: provide sane default to grep_source structEmily Shaffer, May 16, 2019
  2. Junio C HamanoMay 16, 2019
  3. Jonathan NiederMay 16, 2019
  4. Jonathan NiederMay 16, 2019
  5. Emily ShafferMay 16, 2019
  6. grep: provide sane default to grep_source structEmily Shaffer, May 16, 2019
  7. Jeff KingMay 16, 2019
  8. Emily ShafferMay 21, 2019
  9. Jonathan NiederMay 22, 2019
  10. grep: provide sane default to grep_source structEmily Shaffer, May 22, 2019
  11. Jonathan NiederMay 22, 2019
  12. Jeff KingMay 22, 2019
  13. grep: fail if call could output and name is nullEmily Shaffer, May 23, 2019
  14. Jonathan NiederMay 23, 2019
  15. Junio C HamanoMay 28, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.