git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] send-pack: downgrade push options error to warning

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 18, 2020, 17:44 UTC
Message-ID
<xmqqmu9fkcxd.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20200218054009.GD1641086@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
> This makes me a little nervous, because we don't know what those push
> options were supposed to do.
Thanks for stopping this early.  As you said, this die() is very
much deliberate way for us to make sure that we do not damage an
receiving end that is not prepared.
          
Show 8 quoted lines
> So perhaps it would make sense to do one or both of:
>
>  - allow remote.*.pushOptions for specific remotes
>
>  - add a push.pushOptionIfAble key which behaves similarly to
>    push.pushOption, but is quietly ignored if options aren't supported.
>    Then you could put options there that you know are safe to be
>    ignored.
Sensible suggestions.
Previous: Jeff KingNext: Jeff King
Message 4 of 5 in “git-receive-pack: document push options”
  1. 1/2 git-receive-pack: document push optionsDrew DeVault, Feb 17, 2020
  2. 2/2 send-pack: downgrade push options error to warningDrew DeVault, Feb 17, 2020
  3. Jeff KingFeb 18, 2020
  4. Junio C HamanoFeb 18, 2020
  5. Jeff KingFeb 18, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.