git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/2] send-pack: downgrade push options error to warning

From
Drew DeVault <sir@cmpwn.com>
Date
Feb 17, 2020, 14:44 UTC
Message-ID
<20200217144432.43920-2-sir@cmpwn.com>
In-Reply-To
<20200217144432.43920-1-sir@cmpwn.com>

Because the receiving end has to explicitly enable receive.advertisePushOptions, and many servers don't, it doesn't make sense to set push options globally when half of your pushes are just going to die.

Signed-off-by: Drew DeVault <sir@cmpwn.com>
---
 send-pack.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/send-pack.c b/send-pack.c
index 0407841ae8..8c81825e7d 100644
--- a/send-pack.c
+++ b/send-pack.c
@@ -439,7 +439,7 @@ int send_pack(struct send_pack_args *args,
 	use_atomic = atomic_supported && args->atomic;
 
 	if (args->push_options && !push_options_supported)
-		die(_("the receiving end does not support push options"));
+		warning(_("the receiving end does not support push options"));
 
 	use_push_options = push_options_supported && args->push_options;
 
-- 
2.25.0
Previous: Drew DeVaultNext: Jeff King
Message 2 of 5 in “git-receive-pack: document push options”
  1. 1/2 git-receive-pack: document push optionsDrew DeVault, Feb 17, 2020
  2. 2/2 send-pack: downgrade push options error to warningDrew DeVault, Feb 17, 2020
  3. Jeff KingFeb 18, 2020
  4. Junio C HamanoFeb 18, 2020
  5. Jeff KingFeb 18, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.