git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] describe: dont abort too early when searching tags

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 26, 2020, 20:13 UTC
Message-ID
<xmqqmu95hztg.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20200226174853.27404-1-benno@bmevers.de>
benno@bmevers.de writes:
Show 22 quoted lines
> Thus, this commit modifies the stopping condition to only abort
> the search when only one branch is left to search *and* all current
> best candidates are descendants from that branch.
>
> For repositories with a single root, this condition is always
> true: When the search is reduced to a single active branch, the
> current commit must be an ancestor of *all* tag candidates. This
> means that in the common case, this change will have no negative
> performance impact since the same number of commits as before will
> be traversed.
>
> Signed-off-by: Benno Evers <benno@bmevers.de>
> ---
> Changes since v1:
>
>   * Added a paragraph that discusses performance impact to the commit
>     message.
> ...
> +'
> +
> +test_done
> \ No newline at end of file
I'll fix this while queuing.
Thanks for an update.
Previous: benno@bmevers.de
Message 2 of 2 in “describe: dont abort too early when searching tags”
  1. describe: dont abort too early when searching tagsbenno@bmevers.de, Feb 26, 2020
  2. Junio C HamanoFeb 26, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.