From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 26 Feb 2020 20:13:31 GMT
Subject: Re: [PATCH v2] describe: dont abort too early when searching tags
Message-ID: <xmqqmu95hztg.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20200226174853.27404-1-benno@bmevers.de>

benno@bmevers.de writes:

> Thus, this commit modifies the stopping condition to only abort
> the search when only one branch is left to search *and* all current
> best candidates are descendants from that branch.
>
> For repositories with a single root, this condition is always
> true: When the search is reduced to a single active branch, the
> current commit must be an ancestor of *all* tag candidates. This
> means that in the common case, this change will have no negative
> performance impact since the same number of commits as before will
> be traversed.
>
> Signed-off-by: Benno Evers <benno@bmevers.de>
> ---
> Changes since v1:
>
>   * Added a paragraph that discusses performance impact to the commit
>     message.
> ...
> +'
> +
> +test_done
> \ No newline at end of file

I'll fix this while queuing.

Thanks for an update.