git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 0/3] Make the tests that test core.hideDotFiles more robust

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 11, 2020, 21:27 UTC
Message-ID
<xmqqmu7hhfvq.fsf@gitster.c.googlers.com>
In-Reply-To
<pull.603.v3.git.1586612422.gitgitgadget@gmail.com>

"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 8 quoted lines
> We have this feature on Windows where the files starting with a dot can be
> marked hidden (whether a file is hidden by default or not is a matter of
> naming convention on Unix, but it is an explicit flag on Windows). This
> patch improves the regression tests of this feature, and it has been carried
> in Git for Windows for over three years.
>
> Junio, I followed your advice, and did one more thing: the function is now
> renamed also only in 3/3.
Looks good.

I would have renamed it when making it global, exactly for the reason you stated in [3/3], but it's not like we would merge only the first two without the fixup, so it does not matter in practice (as long as other people won't pick up a bad habit from the example, that is).

Thanks.  Let's start merging a lot of things down to 'next'.
Previous: Johannes Schindelin via GitGitGadget
Message 15 of 15 in “mingw: make is_hidden tests in t0001/t5611 more robust”
  1. mingw: make is_hidden tests in t0001/t5611 more robustJohannes Schindelin via GitGitGadget, Apr 8, 2020
  2. Junio C HamanoApr 8, 2020
  3. 0/2 make "is_hidden" even more robustJunio C Hamano, Apr 9, 2020
  4. 1/2 mingw: refactor test_path_is_hidden out to t/test-lib-functions.shJunio C Hamano, Apr 9, 2020
  5. 2/2 t: protect against use of test_path_is_hidden outside MINGWJunio C Hamano, Apr 9, 2020
  6. 0/3 Make the tests that test core.hideDotFiles more robustJohannes Schindelin via GitGitGadget, Apr 10, 2020
  7. 2/3 mingw: make test_path_is_hidden tests in t0001/t5611 more robustJohannes Schindelin via GitGitGadget, Apr 10, 2020
  8. 3/3 t: fix casing of the operating system `Windows`Johannes Schindelin via GitGitGadget, Apr 10, 2020
  9. 1/3 t: consolidate the `is_hidden` functionsJohannes Schindelin via GitGitGadget, Apr 10, 2020
  10. Junio C HamanoApr 10, 2020
  11. 0/3 Make the tests that test core.hideDotFiles more robustJohannes Schindelin via GitGitGadget, Apr 11, 2020
  12. 2/3 mingw: make test_path_is_hidden more robustJohannes Schindelin via GitGitGadget, Apr 11, 2020
  13. 3/3 t: restrict `is_hidden` to be called only on WindowsJohannes Schindelin via GitGitGadget, Apr 11, 2020
  14. 1/3 t: consolidate the `is_hidden` functionsJohannes Schindelin via GitGitGadget, Apr 11, 2020
  15. Junio C HamanoApr 11, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.