Re: [PATCH v2 0/3] Make the tests that test core.hideDotFiles more robust

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 10, 2020, 11:14 UTC
Message-ID: <xmqq5ze7lhi6.fsf@gitster.c.googlers.com>
In-Reply-To: <pull.603.v2.git.1586516583.gitgitgadget@gmail.com>

"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com> writes:

> Junio, I'm sorry that I did not get to send v2 yesterday, and that you spent
> time on the two add-on patches even after I finalized this second iteration
> (but I was first waiting for the PR build to pass and while that happened, I
> got stuck in meeting after meeting).

Heh, mails cross all the time, so there is not much to be sorry, and it is not a race, and it's not much of an issue who sent an equivalent patch to the list first ;-)

A few issues I noticed that are not worth pointing out inline with the patches are

 [1/3] The "consolidate" is a bit uneven.  It keeps the 'windows'
       (lowercase) to pretend to be a pure code movement, while
       adding the "prereq or die" that makes it an impure code
       movement.  If I were doing this, this step would be pure code
       movement, and [3/3] would have the "prereq or die" as its
       main theme, i.e. make sure it is hard to misuse.  [3/3] would
       also do "s/windows/Windows/" as "while at it".

 [2/3] The test numbers on the title is no longer relevant, and I
       would suggest retitling this step.  No matter which test uses
       it currently, or any new uses added in the future to other
       tests, with this patch the helper is more robust, and it was
       the point of [1/3].
 
Thanks.