git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3] gitweb: Replace <base> tag with full URLs (when using PATH_INFO)

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 12, 2020, 21:00 UTC
Message-ID
<xmqqmu44phym.fsf@gitster.c.googlers.com>
In-Reply-To
<20200712183329.3358-1-tobi@isticktoit.net>
Tobias Girstmair <tobi@isticktoit.net> writes:
> using a base tag has the side-effect of not just changing the few URLs
> of gitweb's static resources, but all other relative links (e.g. those
> in a README.html), too.

Sorry, but I am not sure the description is understandable to the intended readers of this sentence.

Where does this README.html come from?

Is it stored in the history of the repository as a blob, and sent to the browser with a call to git_blob_plain() sub? Wouldn't that codepath send the untrusted end-user data as an attachment, in which case relative links in the blob do not get resolved relative to the base URL anyway, no?

Previous: Tobias GirstmairNext: Tobias Girstmair
Message 4 of 10 in “gitweb: Replace <base> tag with full URLs (when using PATH_INFO)”
  1. gitweb: Replace <base> tag with full URLs (when using PATH_INFO)Tobias Girstmair, Jul 11, 2020
  2. gitweb: Replace <base> tag with full URLs (when using PATH_INFO)Tobias Girstmair, Jul 12, 2020
  3. gitweb: Replace <base> tag with full URLs (when using PATH_INFO)Tobias Girstmair, Jul 12, 2020
  4. Junio C HamanoJul 12, 2020
  5. Tobias GirstmairJul 12, 2020
  6. Junio C HamanoJul 13, 2020
  7. Tobias GirstmairJul 13, 2020
  8. Junio C HamanoJul 13, 2020
  9. Tobias GirstmairJul 13, 2020
  10. Tobias GirstmairNov 20, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.