Re: [PATCH v3] gitweb: Replace <base> tag with full URLs (when using PATH_INFO)

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 13, 2020, 04:34 UTC
Message-ID: <xmqqa704owwz.fsf@gitster.c.googlers.com>
In-Reply-To: <20200712230508.GA1000433@isticktoit.net>

Tobias Girstmair <tobi@isticktoit.net> writes:

Show 15 quoted lines

> On Sun, Jul 12, 2020 at 02:00:01PM -0700, Junio C Hamano wrote:
>>Sorry, but I am not sure the description is understandable to the
>>intended readers of this sentence.
>>
>>Where does this README.html come from?
>
> gitweb reads a README.html from each repository to display on the
> summary page. 'man 1 gitweb' has a paragraph on it under
> "Per-repository gitweb configuration".
>
>>Is it stored in the history of the repository as a blob, and sent to
>>the browser with a call to git_blob_plain() sub?  Wouldn't that
>
> No, it's a plain file in a bare repository, placed there either
> manually or by a post-update hook.

OK.

> ... If the user wanted to
> include an image, they'd write <img src="blob_plain/HEAD:/image.png">
> (assuming this patch landed).

And without this patch, the src URL needs to know where this repository appears in the site's URL namespace?

If that is the case, the change makes quite a lot of sense.

Thanks.