Re: Option to allow fsmonitor to run against repos on network file systems

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 1, 2022, 18:41 UTC
Message-ID: <xmqqmtds8ylz.fsf@gitster.g>
In-Reply-To: <16832f8a-c582-23bb-dda9-b7b2597a42eb@jeffhostetler.com>

Jeff Hostetler <git@jeffhostetler.com> writes:

Show 10 quoted lines

> Having said all of that, I did do lots of testing and never had an
> issue with remote drives actually working correctly, so I think it'd
> be fine allow a config setting to optionally allow it.  I just didn't
> want to clutter up things in advance if no one actually wanted to
> use it on remote file systems.
>
> I think it would be fine to have a "fsmonitor.allowRemote" or
> "fsmonitor.allowWindowsRemote" config setting and default them to false
> for now.  Or until we learn which combinations of remote mounts are
> safe and/or problematic.

How about getting rid of "is this remote?" check altogether (which presumably would simplify the logic) and make it totally up to the user of the repository? fsmonitor.disableInRepository that is set in ~/.gitignore and lists the paths to the repositories (like safe.directory does), for which fsmonitor gets disabled, may be a handy mechanism to set up the default (and it can be re-enabled with per-repository core.fsmonitor).