Re: Option to allow fsmonitor to run against repos on network file systems

From: Eric D <eric.decosta@gmail.com>
Date: Jul 1, 2022, 19:15 UTC
Message-ID: <CAMxJVdG5OCgWMN+0aymdVTorrkeViGNy=f49fu7GJE6trwyoWw@mail.gmail.com>
In-Reply-To: <xmqqmtds8ylz.fsf@gitster.g>

One more possibility:

Leave the check, but make it a warning if there are still concerns about running fsmonitor against network file systems. Maybe also provide an option to suppress the warning? Not that much different from having "fsmonitor.allowRemote" I suppose other than by default fsmonitor would "just work" for network mounts.

On Fri, Jul 1, 2022 at 2:41 PM Junio C Hamano <gitster@pobox.com> wrote:

Show 23 quoted lines

>
> Jeff Hostetler <git@jeffhostetler.com> writes:
>
> > Having said all of that, I did do lots of testing and never had an
> > issue with remote drives actually working correctly, so I think it'd
> > be fine allow a config setting to optionally allow it.  I just didn't
> > want to clutter up things in advance if no one actually wanted to
> > use it on remote file systems.
> >
> > I think it would be fine to have a "fsmonitor.allowRemote" or
> > "fsmonitor.allowWindowsRemote" config setting and default them to false
> > for now.  Or until we learn which combinations of remote mounts are
> > safe and/or problematic.
>
> How about getting rid of "is this remote?" check altogether (which
> presumably would simplify the logic) and make it totally up to the
> user of the repository?  fsmonitor.disableInRepository that is set
> in ~/.gitignore and lists the paths to the repositories (like
> safe.directory does), for which fsmonitor gets disabled, may be a
> handy mechanism to set up the default (and it can be re-enabled with
> per-repository core.fsmonitor).
>
>