Re: ps/fetch-output-format
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 12, 2023, 19:33 UTC
- Message-ID
- <xmqqmt29pcoq.fsf@gitster.g>
- In-Reply-To
- <ZF3nFaHjOxt4a3ee@ncase>
Patrick Steinhardt <ps@pks.im> writes:
> We may add below diff to "fetch: introduce `display_format` enum". No > further changes would be required for any of the other patches as we > always explicitly initialize the value already and don't use the > `UNKNOWN` value anywhere.
Yup, if I were writing this series from scratch I wouldn't have added the UNKNOWN one myself, but it is so small thing that we can leave it for those who want to do trivial clean-ups after the dust settles (it could even be one of future microprojects).
Show 21 quoted lines
>
> diff --git a/builtin/fetch.c b/builtin/fetch.c
> index 462fc86b99..6583e31e3d 100644
> --- a/builtin/fetch.c
> +++ b/builtin/fetch.c
> @@ -49,7 +49,6 @@ enum {
> };
>
> enum display_format {
> - DISPLAY_FORMAT_UNKNOWN = 0,
> DISPLAY_FORMAT_FULL,
> DISPLAY_FORMAT_COMPACT,
> DISPLAY_FORMAT_PORCELAIN,
>
> I'm rather indifferent though and feel like re-sending all patches only
> to change this one line of code generates too much noise. But I'm happy
> to adjust in order to make your life easier.
>
> Thanks!
>
> Patrick