Re: [PATCH v2 2/2] osxkeychain: state[] seen=1 to skip unnecessary store operations

From: Junio C Hamano <gitster@pobox.com>
Date: May 12, 2024, 04:09 UTC
Message-ID: <xmqqmsovisc5.fsf@gitster.g>
In-Reply-To: <1f57718abff1d0e234c4145e833424da7be79311.1715428542.git.gitgitgadget@gmail.com>

"Koji Nakamaru via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 5 quoted lines

> From: Koji Nakamaru <koji.nakamaru@gree.net>
>
> Records whether credentials come from get operations and skips
> unnecessary store operations by utilizing the state[] feature, as
> suggested by brian m. carlson.

This step has a problem description that is even sketchier than the previous one. Anticipate questions by the other developers who read this commit 6 months after it is accepted in the mainline (e.g., What problem is there in the current system, why it is bad and worth solving, and how is the patch trying to solve it?) and let your proposed log message answer the questions, as you won't be always sitting next to these developers.

Thanks.