Re: [PATCH] osxkeychain: lock for exclusive execution

From: brian m. carlson <sandals@crustytoothpaste.net>
Date: May 10, 2024, 23:12 UTC
Message-ID: <Zj6p6df2DOVocbNl@tapette.crustytoothpaste.net>
In-Reply-To: <20240510220715.GB1962678@coredump.intra.peff.net>

On 2024-05-10 at 22:07:15, Jeff King wrote:

Show 14 quoted lines

> On Fri, May 10, 2024 at 08:33:08PM +0000, brian m. carlson wrote:
> > All the credential helper needs to do is declare support for that
> > functionality with the appropriate capability and emit the field if it
> > gets that capability on standard input.
> 
> If I understand the protocol, it is just:
> 
>   printf("capability[]=state\n");
>   printf("state[]=osxkeychain:seen=1\n");
> 
> in the helper when it returns a username/password? And I guess the
> matching parse/check on "store".
> 
> Sounds like that would be easy for folks on macOS to play with.

Yup. It may receive `state[]` fields from other helpers, so it needs to check that the entries are its own (presumably starting with `osxkeychain:`) when it reads them, but otherwise, that's it.

-- 
brian m. carlson (they/them or he/him)
Toronto, Ontario, CA