Re: MSan failures in pack-bitmap

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 9, 2024, 18:55 UTC
Message-ID: <xmqqmsnuaqus.fsf@gitster.g>
In-Reply-To: <ZmXKzJ9CpbYTmTwC@nand.local>

Taylor Blau <me@ttaylorr.com> writes:

> Unfortunately, the regression happened in 795006fff4, so this is in a
> released version of Git. But this is all behind a configuration option,
> so affected users can reasonably work around this issue.

Can you elaborate a bit about "reasonably work around"?

I am imagining that you are saying that the user can say "do not use bitmap, because it may be corrupted due to an earlier regression" in some configuration, so that a corrupt bitmap data is not used to further spread the damage, but how does a user find out that on-disc midx is broken and a workaround needs to be employed in the first place? After working around the issue by avoiding to use the corrupt on-disc data while waiting for a fixed version of Git to come, what does the user need to do to start using the now-corrected feature again? Does the fixed code notice there is an existing breakage caused by the regression and remove the broken file automatically?

Thanks.