git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: MSan failures in pack-bitmap

From
Jeff King <peff@peff.net>
Date
Jun 11, 2024, 09:12 UTC
Message-ID
<20240611091248.GA3264564@coredump.intra.peff.net>
In-Reply-To
<20240611080220.GG3248245@coredump.intra.peff.net>
On Tue, Jun 11, 2024 at 04:02:20AM -0400, Jeff King wrote:
Show 12 quoted lines
> > So in short, I think the fix I posted above should be tracked down to
> > 'maint' at least for the 2.45.x series. It will avoid the MSan failures
> > and more importantly the issue I described above. I would also like to
> > find a way to further test this case so that we aren't bit by such a bug
> > in the future.
> 
> I don't think we can test the case where the bug would produce a bogus
> pack, since that implies guessing the uninitialized data. I guess we
> could come up with a case where try_partial_reuse() should say "this is
> OK to reuse", but the bogus pack_int_id prevents it. Which implies
> looking at the resulting pack and checking that some delta is there that
> we expect?
Ah, never mind. I see you worked up a test in the v2 patches you sent.
-Peff
Previous: Jeff King
Message 10 of 10 in “MSan failures in pack-bitmap”
  1. Kyle LippincottJun 8, 2024
  2. Jeff KingJun 8, 2024
  3. Taylor BlauJun 9, 2024
  4. Junio C HamanoJun 9, 2024
  5. Taylor BlauJun 9, 2024
  6. Junio C HamanoJun 9, 2024
  7. Taylor BlauJun 9, 2024
  8. Taylor BlauJun 9, 2024
  9. Jeff KingJun 11, 2024
  10. Jeff KingJun 11, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.