Re: MSan failures in pack-bitmap
On Tue, Jun 11, 2024 at 04:02:20AM -0400, Jeff King wrote:
Show 12 quoted lines
> > So in short, I think the fix I posted above should be tracked down to
> > 'maint' at least for the 2.45.x series. It will avoid the MSan failures
> > and more importantly the issue I described above. I would also like to
> > find a way to further test this case so that we aren't bit by such a bug
> > in the future.
>
> I don't think we can test the case where the bug would produce a bogus
> pack, since that implies guessing the uninitialized data. I guess we
> could come up with a case where try_partial_reuse() should say "this is
> OK to reuse", but the bogus pack_int_id prevents it. Which implies
> looking at the resulting pack and checking that some delta is there that
> we expect?
Ah, never mind. I see you worked up a test in the v2 patches you sent.
-Peff