Re: [PATCH] git: fix paginate handling for commands with DELAY_PAGER_CONFIG

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 22, 2024, 17:21 UTC
Message-ID: <xmqqmshrrxpq.fsf@gitster.g>
In-Reply-To: <CAN0heSoryo-DO6WXKqqASJ5nDLqb3PNNiZv1TP=Pq11wsiSM6A@mail.gmail.com>

Martin Ågren <martin.agren@gmail.com> writes:

Show 13 quoted lines

> Hi Matthew,
> ...
> Actually, no, it's not so much ignoring as *forcing*. Since you force it
> to 0, doesn't that mean that `--paginate` ends up basically being
> `--no-pager`? So `git --paginate branch` is now `git --no-pager branch`?
> That doesn't seem right. An optionless `git branch` would have
> paginated, so adding `--paginate` shouldn't change anything.
>
> But even if we force it to -1 instead (for "maybe"), I'm not sure I
> understand why such an undoing of user intention is wanted. If I run
> `git --paginate tag -a ...`, maybe that's just self-inflicted harm, but
> are we certain that for all the `git foo --bar` which won't respect
> `pager.foo`, that it's also completely crazy to provide `--paginate`?

The whole thing started with

    Calling commands using editor in terminal with `--paginate`
    option will break things. For example `git --paginate config
    --edit`.

which many of us may respond with "it hurts? do not do it then", so I agree with you that a fallout would be worse than the problem the change is trying to "fix".