Re: [PATCH] git: fix paginate handling for commands with DELAY_PAGER_CONFIG
- From
- Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
- Date
- Nov 22, 2024, 18:50 UTC
- Message-ID
- <1d3aa75d-e816-4544-b10a-ab1a215dcd83@app.fastmail.com>
- In-Reply-To
- <20241120101741.8225-1-dev.mbstr@gmail.com>
I was originally not going to nitpick this in case the patch would go through review (not to disrupt).
On Wed, Nov 20, 2024, at 11:17, Matthew Bystrin wrote:
Show 6 quoted lines
> Calling commands using editor in terminal with `--paginate` option will > break things. For example `git --paginate config --edit`. Add extra > check to ignore paginate flag in case command have DELAY_PAGER_CONFIG > set. > > Relates: cd878a206e8c (t7006: add tests for how git config paginates)
Trailers in this project usually credit/mention people. Related commits tend to be mentioned in the body (the rest of the body) of the commit message.
> Signed-off-by: Matthew Bystrin <dev.mbstr@gmail.com>
-- Kristoffer Haugsbakk