git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 2/5] odb: decouple source path comparisons from `the_repository`

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 20, 2026, 15:59 UTC
Message-ID
<xmqqmrugsryl.fsf@gitster.g>
In-Reply-To
<20260817-pks-odb-eagerly-prepare-alternates-v3-2-1115a7e02467@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 17 quoted lines
> When registering alternates we deduplicate object database sources by
> their path so that the same source won't be added twice. Ever since
> cf2dc1c238 (speed up alt_odb_usable() with many alternates, 2021-07-07)
> this duplicate check is backed by a map keyed by the source's path,
> using `fspathhash()` and `fspatheq()` as hash and equality functions,
> respectively.
>
> These functions are problematic in this context for two reasons:
>
>   - They implicitly depend on `the_repository` instead of the
>     repository that owns the object database.
>
>   - They derive case-sensitivity from `repo_ignore_case()`, which
>     returns a default value in case the repository's configuration has
>     not been parsed yet. Object database sources may be registered
>     before that is the case, so the answer may flip depending on when a
>     source gets registered.

As you later mention, we can always hash case-insensitively with the downside of additional possibilities of hash collisions. I would not be too worried about the hash side, but the above makes me wonder what should happen in the eq() function when a repository uses object databases living on separate filesystems, some being case-insensitive and others being case-sensitive.

In any case, I wonder if 'core.ignoreCase' should even be a part of the repository configuration. Do we need to support configurations where some parts of the repository are backed by a case-insensitive filesystem while others are not? And if so, how? It almost feels as if each of these object database sources needs to report "This is the path to my filesystem location, and the path may have case-different aliases" and "My path is on a case-sensitive filesystem so you do not have to worry about it clashing", and we need to compare them accordingly.

Show 8 quoted lines
> Overall it's quite debatable whether all of this complexity really is
> worth it, out of two reasons:
>
>   - We could linearly search through all sources to find duplicates. But
>     the mentioned commit cares about cases with thousands of alternates,
>     and a linear search would of course regress performance quite a bit.
>     This doesn't really feel like a reasonable case to care about, but I
>     don't feel comfortable regressing it anyway.

Linear or hashed, the issue of what the definition of eq() should be remains. Discarding the hash map does not help at all, I suspect. Am I missing something?

Show 5 quoted lines
>   - It's dubious whether we should handle "core.ignoreCase" in the first
>     place. The downside would be that we might add the same alternate
>     multiple times with different casing. But this is an edge case, and
>     it's not even fully fixed because we don't resolve symlinks or
>     mountpoints, either.

Do we know if these all come directly from the way the user spelled these paths?

Unless there is a demon that randomly flips the character case in a pathname once it is obtained from the user or readdir() before it gets to this code path, an easy way out may be to tell users "don't spell the pathnames inconsistently" or its equivalent, "do spell them exactly the way readdir() would report on your system", with "if you fail to do so, bad things will happen". I suspect that the bad thing in this particular case is merely that a search in the alternates is made unnecessarily inefficient due to duplicates, so it may be a reasonable alternative.

Alternatively, we can even say "your repository cannot span filesystems with different case sensitivities"; I am sure there would be some users affected by such a declaration, but I do not know how much we should care.

Show 21 quoted lines
> +/*
> + * NEEDSWORK: we're using "core.ignoreCase" to deduplicate alternates that
> + * _may_ be the same. This requires quite a bit of boilerplate for dubious
> + * benefit:
> + *
> + *   - Duplicating alternates should really only lead to regressed performance.
> + *
> + *   - We don't properly resolve symlinks or mointpoints, so we may still end
> + *     up duplicating alternates.
> + *
> + *   - The value may be lying, in which case we might deduplicate alternates
> + *     that are in fact not mapping to the same directory.
> + *
> + * We should investigate whether we can remove this whole mechanism outright.
> + */
> +static int odb_source_paths_cmp(struct object_database *o,
> +				const char *a, const char *b)
> +{
> +	if (o->source_paths_icase < 0) {
> +		int icase = 0;
> +		repo_config_get_bool(o->repo, "core.ignorecase", &icase);

I suspect accessing o->repo should be safe even in the initialization sequence, simply because "o->repo = repo" is done as the first thing in odb_new(), but do we know o->repo->initialized is true in this code path? Refraining from making that call and assuming a case senstivie comparison may be necessary when o->repo is not yet initialized.

Show 5 quoted lines
> +		o->source_paths_icase = icase;
> +	}
> +
> +	return o->source_paths_icase ? strcasecmp(a, b) : strcmp(a, b);
> +}
Previous: Patrick SteinhardtNext: Patrick Steinhardt
Message 41 of 47 in “odb: eagerly load alternates”
  1. 0/4 odb: eagerly load alternatesPatrick Steinhardt, Aug 10, 2026
  2. 1/4 odb: decouple source path comparisons from `the_repository`Patrick Steinhardt, Aug 10, 2026
  3. Justin ToblerAug 11, 2026
  4. Patrick SteinhardtAug 12, 2026
  5. 2/4 odb: eagerly initialize alternatesPatrick Steinhardt, Aug 10, 2026
  6. Justin ToblerAug 11, 2026
  7. Patrick SteinhardtAug 12, 2026
  8. 3/4 odb: drop `loaded_alternates` fieldPatrick Steinhardt, Aug 10, 2026
  9. Justin ToblerAug 11, 2026
  10. 4/4 odb: drop `alternates_db` fieldPatrick Steinhardt, Aug 10, 2026
  11. Justin ToblerAug 11, 2026
  12. Patrick SteinhardtAug 12, 2026
  13. 0/4 odb: eagerly load alternatesPatrick Steinhardt, Aug 12, 2026
  14. 1/4 odb: decouple source path comparisons from `the_repository`Patrick Steinhardt, Aug 12, 2026
  15. Karthik NayakAug 13, 2026
  16. Patrick SteinhardtAug 13, 2026
  17. Karthik NayakAug 14, 2026
  18. Jeff KingAug 14, 2026
  19. Junio C HamanoAug 14, 2026
  20. Jeff KingAug 14, 2026
  21. Patrick SteinhardtAug 17, 2026
  22. Patrick SteinhardtAug 17, 2026
  23. Jeff KingAug 17, 2026
  24. Patrick SteinhardtAug 17, 2026
  25. Jeff KingAug 17, 2026
  26. Jeff KingAug 17, 2026
  27. Jeff KingAug 14, 2026
  28. Patrick SteinhardtAug 17, 2026
  29. 2/4 odb: eagerly initialize alternatesPatrick Steinhardt, Aug 12, 2026
  30. 3/4 odb: drop `loaded_alternates` fieldPatrick Steinhardt, Aug 12, 2026
  31. Karthik NayakAug 13, 2026
  32. 4/4 odb: drop `alternates_db` fieldPatrick Steinhardt, Aug 12, 2026
  33. Junio C HamanoAug 12, 2026
  34. Patrick SteinhardtAug 13, 2026
  35. Karthik NayakAug 13, 2026
  36. Justin ToblerAug 13, 2026
  37. 0/5 odb: eagerly load alternatesPatrick Steinhardt, Aug 17, 2026
  38. 1/5 setup: create ref and object databases after config is writtenPatrick Steinhardt, Aug 17, 2026
  39. Karthik NayakAug 20, 2026
  40. 2/5 odb: decouple source path comparisons from `the_repository`Patrick Steinhardt, Aug 17, 2026
  41. Junio C HamanoAug 20, 2026
  42. Patrick SteinhardtAug 21, 2026
  43. Junio C HamanoAug 21, 2026
  44. 3/5 odb: eagerly initialize alternatesPatrick Steinhardt, Aug 17, 2026
  45. 4/5 odb: drop `loaded_alternates` fieldPatrick Steinhardt, Aug 17, 2026
  46. 5/5 odb: drop `alternates_db` fieldPatrick Steinhardt, Aug 17, 2026
  47. Karthik NayakAug 20, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.