git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 2/5] odb: decouple source path comparisons from `the_repository`

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 21, 2026, 15:19 UTC
Message-ID
<xmqqik53qz5j.fsf@gitster.g>
In-Reply-To
<aof-t_bRzC0u1hHj@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
> I don't feel comfortable removing that mechanism though. There's always
> that one person relying on those weird edge cases.

I do not, either, and more importantly, removing the hashing mechanism does not help an iota here to deal with case insensitive filesystems.

Show 19 quoted lines
>> ... an easy way out may be to tell users "don't
>> spell the pathnames inconsistently" or its equivalent, "do spell
>> them exactly the way readdir() would report on your system", with "if
>> you fail to do so, bad things will happen".  I suspect that the bad
>> thing in this particular case is merely that a search in the
>> alternates is made unnecessarily inefficient due to duplicates, so it
>> may be a reasonable alternative.
>
> Yeah. All of this is really just caused by the fact that there is no
> platform-agnostic way to check whether two directories are the same
> thing. Which is kind of surprising, if you ask me.
>
>> Alternatively, we can even say "your repository cannot span
>> filesystems with different case sensitivities"; I am sure there
>> would be some users affected by such a declaration, but I do not
>> know how much we should care.
>
> I'm hesitant to go there, as that would retroactively introduce
> limitations that could break ...

Yup. Which means the simplest way out would be to do a "best effort" case-insensitive match when there is a hint that the platform might be using a case insensitive filesystem.

And that in turn gives us a direction to solve this part ...
Show 17 quoted lines
>> > +/*
>> > + * NEEDSWORK: we're using "core.ignoreCase" to deduplicate alternates that
>> > + * _may_ be the same. This requires quite a bit of boilerplate for dubious
>> > ...
>> > +static int odb_source_paths_cmp(struct object_database *o,
>> > +				const char *a, const char *b)
>> > +{
>> > +	if (o->source_paths_icase < 0) {
>> > +		int icase = 0;
>> > +		repo_config_get_bool(o->repo, "core.ignorecase", &icase);
>> 
>> I suspect accessing o->repo should be safe even in the
>> initialization sequence, simply because "o->repo = repo" is done as
>> the first thing in odb_new(), but do we know o->repo->initialized is
>> true in this code path?  Refraining from making that call and
>> assuming a case senstivie comparison may be necessary when o->repo
>> is not yet initialized.

...which is that, since case-insensitivity support is at most best effort, we do not really care if o->repo is not initialized. The code can stay as-is, and if the user spelled the path to a single alternate object store using two different cases in two places, causing the code to treat them as two different entities, the effect is merely an extra search of the "second copy" (which is guaranteed to find nothing, after a search in the first copy finds no object they are looking for)s, a minor performance penalty

Previous: Patrick SteinhardtNext: Patrick Steinhardt
Message 43 of 47 in “odb: eagerly load alternates”
  1. 0/4 odb: eagerly load alternatesPatrick Steinhardt, Aug 10, 2026
  2. 1/4 odb: decouple source path comparisons from `the_repository`Patrick Steinhardt, Aug 10, 2026
  3. Justin ToblerAug 11, 2026
  4. Patrick SteinhardtAug 12, 2026
  5. 2/4 odb: eagerly initialize alternatesPatrick Steinhardt, Aug 10, 2026
  6. Justin ToblerAug 11, 2026
  7. Patrick SteinhardtAug 12, 2026
  8. 3/4 odb: drop `loaded_alternates` fieldPatrick Steinhardt, Aug 10, 2026
  9. Justin ToblerAug 11, 2026
  10. 4/4 odb: drop `alternates_db` fieldPatrick Steinhardt, Aug 10, 2026
  11. Justin ToblerAug 11, 2026
  12. Patrick SteinhardtAug 12, 2026
  13. 0/4 odb: eagerly load alternatesPatrick Steinhardt, Aug 12, 2026
  14. 1/4 odb: decouple source path comparisons from `the_repository`Patrick Steinhardt, Aug 12, 2026
  15. Karthik NayakAug 13, 2026
  16. Patrick SteinhardtAug 13, 2026
  17. Karthik NayakAug 14, 2026
  18. Jeff KingAug 14, 2026
  19. Junio C HamanoAug 14, 2026
  20. Jeff KingAug 14, 2026
  21. Patrick SteinhardtAug 17, 2026
  22. Patrick SteinhardtAug 17, 2026
  23. Jeff KingAug 17, 2026
  24. Patrick SteinhardtAug 17, 2026
  25. Jeff KingAug 17, 2026
  26. Jeff KingAug 17, 2026
  27. Jeff KingAug 14, 2026
  28. Patrick SteinhardtAug 17, 2026
  29. 2/4 odb: eagerly initialize alternatesPatrick Steinhardt, Aug 12, 2026
  30. 3/4 odb: drop `loaded_alternates` fieldPatrick Steinhardt, Aug 12, 2026
  31. Karthik NayakAug 13, 2026
  32. 4/4 odb: drop `alternates_db` fieldPatrick Steinhardt, Aug 12, 2026
  33. Junio C HamanoAug 12, 2026
  34. Patrick SteinhardtAug 13, 2026
  35. Karthik NayakAug 13, 2026
  36. Justin ToblerAug 13, 2026
  37. 0/5 odb: eagerly load alternatesPatrick Steinhardt, Aug 17, 2026
  38. 1/5 setup: create ref and object databases after config is writtenPatrick Steinhardt, Aug 17, 2026
  39. Karthik NayakAug 20, 2026
  40. 2/5 odb: decouple source path comparisons from `the_repository`Patrick Steinhardt, Aug 17, 2026
  41. Junio C HamanoAug 20, 2026
  42. Patrick SteinhardtAug 21, 2026
  43. Junio C HamanoAug 21, 2026
  44. 3/5 odb: eagerly initialize alternatesPatrick Steinhardt, Aug 17, 2026
  45. 4/5 odb: drop `loaded_alternates` fieldPatrick Steinhardt, Aug 17, 2026
  46. 5/5 odb: drop `alternates_db` fieldPatrick Steinhardt, Aug 17, 2026
  47. Karthik NayakAug 20, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.