Re: [PATCH v3] diff-delta: use safe integer arithmetic
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 25, 2026, 18:10 UTC
- Message-ID
- <xmqqmrs1y7kj.fsf@gitster.g>
- In-Reply-To
- <CABh_KWhDcPM6rJROmVd7_oGZ7i3tmX5da-DZX=KJmvSyCxNH_A@mail.gmail.com>
Srujith Poojary <poojarysrujith@gmail.com> writes:
Show 7 quoted lines
> Thank you for the detailed correction. > > I have expanded the commit message to include the step-by-step > breakdown for both the unpacked and packed index allocations, > detailing the caps on hsize (2^26) and entries (2^28) alongside struct > padding on 32-bit systems. I also corrected the phrasing regarding > (hsize + 1) being passed as an argument to st_add3().
It seems that the text of v4 did not "detail" anything like that; you just parroted the conclusion, the final numbers I gave you, without giving any hint for the readers to validate the math. The readers who are interested in validating are forced to figure out how many bytes your calculation assumes each struct type involved consume---and if they find that your conclusion is wrong, they have no clue where in your computation things went wrong.