git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] t1010: add basic tests for mktree --batch

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 11, 2026, 21:50 UTC
Message-ID
<xmqqmrrfm418.fsf@gitster.g>
In-Reply-To
<pull.2270.v2.git.1794348807240.gitgitgadget@gmail.com>
"Roger Koranteng via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 17 quoted lines
> From: Roger Koranteng <rogerkorantenng@gmail.com>
>
> The only "mktree --batch" test in t1010 is the one checking that it
> survives a concurrent repack. Nothing covers basic batch mode, which
> is how the leak fixed in 6272f3bd17 (mktree: plug per-tree leak in
> --batch mode, 2026-08-29) went unnoticed.
>
> Add a few tests for it. Two trees in one batch should get the same
> IDs as running plain "mktree" on each, a trailing blank line should
> not add an extra tree, -z input should work, and a tree that names a
> missing object should make mktree die after printing the trees before
> it. While at it, check that a blank line is rejected without --batch.
>
> Suggested-by: Jeff King <peff@peff.net>
> Tested-by: Laveesh Bansal <laveeshb@laveeshbansal.com>
> Signed-off-by: Roger Koranteng <rogerkorantenng@gmail.com>
> ---
Thanks, for writing and testing.  Queued.
Previous: Roger Koranteng via GitGitGadget
Message 4 of 4 in “t1010: add basic tests for mktree --batch”
  1. t1010: add basic tests for mktree --batchRoger Koranteng via GitGitGadget, Oct 20, 2026
  2. Laveesh BansalNov 9, 2026
  3. t1010: add basic tests for mktree --batchRoger Koranteng via GitGitGadget, Nov 10, 2026
  4. Junio C HamanoNov 11, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.