From: Junio C Hamano Date: Wed, 11 Nov 2026 21:50:11 GMT Subject: Re: [PATCH v2] t1010: add basic tests for mktree --batch Message-ID: In-Reply-To: "Roger Koranteng via GitGitGadget" writes: > From: Roger Koranteng > > The only "mktree --batch" test in t1010 is the one checking that it > survives a concurrent repack. Nothing covers basic batch mode, which > is how the leak fixed in 6272f3bd17 (mktree: plug per-tree leak in > --batch mode, 2026-08-29) went unnoticed. > > Add a few tests for it. Two trees in one batch should get the same > IDs as running plain "mktree" on each, a trailing blank line should > not add an extra tree, -z input should work, and a tree that names a > missing object should make mktree die after printing the trees before > it. While at it, check that a blank line is rejected without --batch. > > Suggested-by: Jeff King > Tested-by: Laveesh Bansal > Signed-off-by: Roger Koranteng > --- Thanks, for writing and testing. Queued.