Re: Git on Mac OS X 10.4.10
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 15, 2014, 16:29 UTC
- Message-ID
- <xmqqlhqp1zt1.fsf@gitster.dls.corp.google.com>
- In-Reply-To
- <273241271546c07e692ae93774993f5@74d39fa044aa309eaea14b9f57fe79c>
"Kyle J. McKay" <mackyle@gmail.com> writes:
Show 19 quoted lines
> On Aug 14, 2014, at 16:18, Junio C Hamano wrote: > >> Markus Hitter <mah@jump-ing.de> writes: >> >>>> The <CommonCrypto/CommonHMAC.h> is in Mac OS X 10.6 .. 10.9, >>>> but not in 10.4 (I don't know about 10.5). > > That header is new with 10.5 > >> Is this about platform dependency, or what the end user happens to >> choose to install (in other words, is there an add-on users of 10.4 >> can choose to add, which allows them to use that header)? > > Nope, it's a platform dependency. Not available prior to 10.5. > > The below patch does the right thing. Conveniently there's already > a test for 10.4 and earlier so only a single line need be added. > > --Kyle
Nice. Use of APPLE_COMMON_CRYPTO thing is not new to the upcoming release, so let me queue it for the next development cycle, not applying directly before curring 2.1 release today.
Thanks.
Show 24 quoted lines
> > ---- 8< ---- > Subject: [PATCH] config.mak.uname: set NO_APPLE_COMMON_CRYPTO on older systems > > Older MacOS systems prior to 10.5 do not have the CommonCrypto > support Git uses so set NO_APPLE_COMMON_CRYPTO on those systems. > > Signed-off-by: Kyle J. McKay <mackyle@gmail.com> > --- > config.mak.uname | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/config.mak.uname b/config.mak.uname > index 7846bd76..f8e12c96 100644 > --- a/config.mak.uname > +++ b/config.mak.uname > @@ -88,6 +88,7 @@ ifeq ($(uname_S),Darwin) > NEEDS_LIBICONV = YesPlease > ifeq ($(shell expr "$(uname_R)" : '[15678]\.'),2) > OLD_ICONV = UnfortunatelyYes > + NO_APPLE_COMMON_CRYPTO = YesPlease > endif > ifeq ($(shell expr "$(uname_R)" : '[15]\.'),2) > NO_STRLCPY = YesPlease