git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Git on Mac OS X 10.4.10

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 15, 2014, 16:29 UTC
Message-ID
<xmqqlhqp1zt1.fsf@gitster.dls.corp.google.com>
In-Reply-To
<273241271546c07e692ae93774993f5@74d39fa044aa309eaea14b9f57fe79c>
"Kyle J. McKay" <mackyle@gmail.com> writes:
Show 19 quoted lines
> On Aug 14, 2014, at 16:18, Junio C Hamano wrote:
>
>> Markus Hitter <mah@jump-ing.de> writes:
>>
>>>> The  <CommonCrypto/CommonHMAC.h> is in Mac OS X 10.6 .. 10.9,
>>>> but not in 10.4 (I don't know about 10.5).
>
> That header is new with 10.5
>
>> Is this about platform dependency, or what the end user happens to
>> choose to install (in other words, is there an add-on users of 10.4
>> can choose to add, which allows them to use that header)?
>
> Nope, it's a platform dependency.  Not available prior to 10.5.
>
> The below patch does the right thing.  Conveniently there's already
> a test for 10.4 and earlier so only a single line need be added.
>
> --Kyle

Nice. Use of APPLE_COMMON_CRYPTO thing is not new to the upcoming release, so let me queue it for the next development cycle, not applying directly before curring 2.1 release today.

Thanks.
Show 24 quoted lines
>
> ---- 8< ----
> Subject: [PATCH] config.mak.uname: set NO_APPLE_COMMON_CRYPTO on older systems
>
> Older MacOS systems prior to 10.5 do not have the CommonCrypto
> support Git uses so set NO_APPLE_COMMON_CRYPTO on those systems.
>
> Signed-off-by: Kyle J. McKay <mackyle@gmail.com>
> ---
>  config.mak.uname | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/config.mak.uname b/config.mak.uname
> index 7846bd76..f8e12c96 100644
> --- a/config.mak.uname
> +++ b/config.mak.uname
> @@ -88,6 +88,7 @@ ifeq ($(uname_S),Darwin)
>  	NEEDS_LIBICONV = YesPlease
>  	ifeq ($(shell expr "$(uname_R)" : '[15678]\.'),2)
>  		OLD_ICONV = UnfortunatelyYes
> +		NO_APPLE_COMMON_CRYPTO = YesPlease
>  	endif
>  	ifeq ($(shell expr "$(uname_R)" : '[15]\.'),2)
>  		NO_STRLCPY = YesPlease
Previous: Markus HitterNext: Junio C Hamano
Message 10 of 14 in “Git on Mac OS X 10.4.10”
  1. Markus HitterAug 14, 2014
  2. Torsten BögershausenAug 14, 2014
  3. Markus HitterAug 14, 2014
  4. Jonathan NiederAug 14, 2014
  5. Markus HitterAug 15, 2014
  6. Junio C HamanoAug 14, 2014
  7. Kyle J. McKayAug 15, 2014
  8. Eric SunshineAug 15, 2014
  9. Markus HitterAug 15, 2014
  10. Junio C HamanoAug 15, 2014
  11. Junio C HamanoAug 15, 2014
  12. Kyle J. McKayAug 15, 2014
  13. Junio C HamanoAug 15, 2014
  14. Kyle J. McKayAug 15, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.