Re: Git on Mac OS X 10.4.10
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Aug 15, 2014, 09:39 UTC
- Message-ID
- <CAPig+cSGs-MzG=nG7ONRvcMhnrJx4vUri2d5nHovQiQ9w+ckDQ@mail.gmail.com>
- In-Reply-To
- <273241271546c07e692ae93774993f5@74d39fa044aa309eaea14b9f57fe79c>
On Fri, Aug 15, 2014 at 3:46 AM, Kyle J. McKay <mackyle@gmail.com> wrote:
Show 17 quoted lines
> On Aug 14, 2014, at 16:18, Junio C Hamano wrote: > >> Markus Hitter <mah@jump-ing.de> writes: >> >>>> The <CommonCrypto/CommonHMAC.h> is in Mac OS X 10.6 .. 10.9, >>>> but not in 10.4 (I don't know about 10.5). > > That header is new with 10.5 > >> Is this about platform dependency, or what the end user happens to >> choose to install (in other words, is there an add-on users of 10.4 >> can choose to add, which allows them to use that header)? > > Nope, it's a platform dependency. Not available prior to 10.5. > > The below patch does the right thing. Conveniently there's already > a test for 10.4 and earlier so only a single line need be added.
I tested with Mac OS X 10.5 (and 10.9) to verify that there is no regression. Works fine.
Show 27 quoted lines
> --Kyle > > ---- 8< ---- > Subject: [PATCH] config.mak.uname: set NO_APPLE_COMMON_CRYPTO on older systems > > Older MacOS systems prior to 10.5 do not have the CommonCrypto > support Git uses so set NO_APPLE_COMMON_CRYPTO on those systems. > > Signed-off-by: Kyle J. McKay <mackyle@gmail.com> > --- > config.mak.uname | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/config.mak.uname b/config.mak.uname > index 7846bd76..f8e12c96 100644 > --- a/config.mak.uname > +++ b/config.mak.uname > @@ -88,6 +88,7 @@ ifeq ($(uname_S),Darwin) > NEEDS_LIBICONV = YesPlease > ifeq ($(shell expr "$(uname_R)" : '[15678]\.'),2) > OLD_ICONV = UnfortunatelyYes > + NO_APPLE_COMMON_CRYPTO = YesPlease > endif > ifeq ($(shell expr "$(uname_R)" : '[15]\.'),2) > NO_STRLCPY = YesPlease > -- > 1.8.5