Re: [PATCH 2/2] receive-pack: support push-to-checkout hook

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 2, 2014, 17:19 UTC
Message-ID: <xmqqlhmqm0k2.fsf@gitster.dls.corp.google.com>
In-Reply-To: <alpine.DEB.1.00.1412021804210.13845@s15462909.onlinehome-server.info>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> ... (i.e. by only lightly testing obscure code paths that will be
> executed rarely, risking bugs in favor of adding tests when fixing said
> bugs when – and if – they arise).

I'd like to learn a bit more about this part, not because I want to say you are wrong, but because I want to find out what you say is practically useful and can be adopted by the project.

The part I find most troublesome is this. Without tests covering "obscure" cases, how would you expect to notice when the codebase regresses, at which point you plan to fix and add tests for the fix?

Not that I think the "minimally these need to be tested" list I sent earlier are anything obscure (they are all essential part of the feature; without them working, the feature would not be useful).