Re: [PATCH 2/2] receive-pack: support push-to-checkout hook

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Dec 2, 2014, 17:12 UTC
Message-ID: <alpine.DEB.1.00.1412021804210.13845@s15462909.onlinehome-server.info>
In-Reply-To: <xmqqppc2m1fz.fsf@gitster.dls.corp.google.com>

Hi Junio,

On Tue, 2 Dec 2014, Junio C Hamano wrote:

Show 13 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> >> Not really.  You need to remember that we write tests not to show
> >> off the new shiny, but to protect essential invariants from being
> >> broken by careless others attempting to rewrite the implementation
> >> in the future.
> >
> > Fair enough. You are the boss.
> >
> > I am not, therefore it does not matter what I think,
> 
> It is not that it does not matter because you are not the boss; it
> is just that when you are wrong, you are wrong.

Please, there is no need to get emotional, let alone personal.

I am not really interested in challenging your policy regarding the test suite, even if it does hurt my development style where I want to run the test suite frequently but its tests just take too long because their focus is more on thoroughness rather than trying to save time in the manner I suggested (i.e. by only lightly testing obscure code paths that will be executed rarely, risking bugs in favor of adding tests when fixing said bugs when – and if – they arise). There is nothing inherently wrong in the way you want to have the test suite, it is a matter of preference, that is all. I would like a more light-weight test suite that runs much faster, you want a thorough one, even if it takes more time to run.

So: you are the boss, you do the things you do, and my opinion does not
matter. I say this most pragmatically, to save more time by ending this
discussion now. There are no hard feelings on my side.

Ciao, Johannes