git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Introducing a test_create_repo_bare (was Re: [PATCHv2 6/6] t5543-atomic-push.sh: add basic tests for atomic pushes)

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 18, 2014, 17:06 UTC
Message-ID
<xmqqlhm47uqz.fsf@gitster.dls.corp.google.com>
In-Reply-To
<20141218002825.GQ29365@google.com>
Jonathan Nieder <jrnieder@gmail.com> writes:
Show 8 quoted lines
> Junio C Hamano wrote:
>
>> The issue is if some existing tests will be helped, if we had such a
>> helper.
>
> Since both bin-wrappers/git and test-lib.sh set GIT_TEMPLATE_DIR and
> templates/blt doesn't contain any enabled hooks, I don't see how such
> a helper would be useful.

Probably bin-wrappers/git has gained it after test_setup_repo protected itself manually, and I obviously forgot about it. I agree with your conclusion below, if test_create_repo has become a no-op these days. Thanks.

> If making things more consistent were worth the churn, then if
> anything it would make sense to make test_create_repo private to the
> setup code in test-lib.sh and to use plain 'git init <directory>' in
> tests.
Previous: Jonathan Nieder
Message 5 of 5 in “Introducing a test_create_repo_bare (was Re: [PATCHv2 6/6] t5543-atomic-push.sh: add basic tests for atomic pushes)”
  1. Stefan BellerDec 17, 2014
  2. Junio C HamanoDec 17, 2014
  3. Stefan BellerDec 18, 2014
  4. Jonathan NiederDec 18, 2014
  5. Junio C HamanoDec 18, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.