Introducing a test_create_repo_bare (was Re: [PATCHv2 6/6] t5543-atomic-push.sh: add basic tests for atomic pushes)

From: Stefan Beller <sbeller@google.com>
Date: Dec 17, 2014, 23:20 UTC
Message-ID: <CAGZ79kY=TP31VJxPZnjb04og-vHU+-c4d+AgAkis2Q7yeDeXbg@mail.gmail.com>

On Tue, Dec 16, 2014 at 11:46 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 10 quoted lines

>> +     (
>> +             cd upstream && git config receive.denyCurrentBranch warn
>> +     ) &&
>
> I was wondering how you would do this part after suggesting use of
> test_create_repo, knowing very well that one of them was a bare one
> ;-).
>
> We might want to extend test_create_repo to allow creating a bare
> repository, but this is also OK.

So I searching through all the tests, where it would make sense to do that. I searched for "denyCurrentBranch" and came up with this list where I think it makes sense to replace (git init | test_create_repo | or alike) by a test_create_repo_bare or add the --bare option to test_create_repo

places where test_create_repo_bare is easily introducable: t5517-push-mirror.sh # setup an upstream repo t5543-atomic-push.sh # setup an upstream repo t5701-clone-local.sh # Test 'clone empty repository'

not as easy: t5400-send-pack.sh # we commit to that repo while being inside t5405-send-pack-rewind.sh # we commit to that repo while being inside t5516-fetch-push.sh # we test the various denyCurrentBranch options

unsure: t5522-pull-symlink.sh # just cloning the repo

So I think we don't need the test_create_repo_bare yet.

Thanks, Stefan