Re: [PATCH 3/4] submodule--helper list: lose the extra prefix option

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 25, 2016, 17:01 UTC
Message-ID: <xmqqlh564hm3.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAGZ79kZ684W46df9zPQATr3zWKt+e1BhGY6DZ84psfXWH4tGNw@mail.gmail.com>

Stefan Beller <sbeller@google.com> writes:

Show 7 quoted lines

> The other reason you gave below is also convincing: By having it in the prefix,
> the C code is more likely correct and future proof.
>
> On rewriting the whole submodule command in C (probably
> reiterating): It is not my endgoal to rewrite every submodule
> related part in C. It would be nice if it would happen eventually,
> but for now I only rewrite parts that I need in C.

Well, what you personally would want to do yourself is irrelevant. Doing submodule--helper in such a way that it is sufficient in a half-way conversion but cannot be reused in future full rewrite is something we would want to avoid, whether you would be doing the full rewrite in the future. In fact, if you are not inclined to do so yourself, that is one more reason to make sure that the C pieces in submodule--helper are reusable (i.e. your "correct and future proof" above); otherwise you'd be making it _more_ difficult for other people who would want to pick it up where you left.