Re: [PATCH 4/4] submodule: add more tests for recursive submodule behavior

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Mar 25, 2016, 00:25 UTC
Message-ID: <CAPig+cS8NSDb=apvtLHQL-Ph=RB0CTashhZMnQ3DkcLfnzB9ww@mail.gmail.com>
In-Reply-To: <1458862468-12460-5-git-send-email-sbeller@google.com>

On Thu, Mar 24, 2016 at 7:34 PM, Stefan Beller <sbeller@google.com> wrote:

> This adds a test for "submodule update", wich calls "submodule update"

s/wich/which/

> from an untracked repository in the superproject. When doing creating

Grammo: "doing creating"

Show 10 quoted lines

> the parent patch a similar test failed for "submodule sync", but
> all tests passed for "submodule update". It took me a long time
> to figure out this was a difference in test coverage instead of
> commands behaving differently. Let's improve the test coverage such
> to make it a better place.
>
> When trying to fix the issue in the parent patch I could get
> the test suite passing when removing the $@ argument from module_list
> in the sync command. This also indicates a low test coverage, so
> fix that.

These two paragraphs are almost entirely commentary, thus probably belong below the "---" line. I'm having a difficult time trying to decipher from this commit message what this patch is actually about. Perhaps the commit message could do a better job explaining exactly what shortcoming(s) it's addressing.

Show 9 quoted lines

> Signed-off-by: Stefan Beller <sbeller@google.com>
> ---
> diff --git a/t/t7406-submodule-update.sh b/t/t7406-submodule-update.sh
> @@ -774,4 +774,16 @@ test_expect_success 'submodule update --recursive drops module name before recur
> +test_expect_success 'submodule update --recursive works from subdirectory' '
> +       (cd super2 &&
> +        (cd deeper/submodule/subsubmodule &&
> +         git checkout HEAD^
> +        ) &&

Maybe use -C and drop the sub-subshell:

    git -C deeper/submodule/subsubmodule checkout HEAD^

Show 6 quoted lines

> +        mkdir untracked &&
> +        cd untracked &&
> +        git submodule update --recursive >actual &&
> +        test_i18ngrep "Submodule path .../deeper/submodule/subsubmodule.: checked out" actual
> +       )
> +'