Re: Segfault in the attr stack

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 1, 2016, 22:35 UTC
Message-ID: <xmqqlh2ownab.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAGZ79kZ6dh7AP5b5N_2RRHQmq=OKpr05JEwyOCbfOj6KWjFC2A@mail.gmail.com>

Stefan Beller <sbeller@google.com> writes:

Show 9 quoted lines

> I propose to not escape commas, but use
> white spaces instead, i.e.
>
>     git status ':(attr:whitespace=indent trail space,attr:label=with
> more values)' ':attr(attr:foo:bar)'
>
> would match
> * all files that have the whitespace AND the label setting (matching
> exactly the values)

"attr:whitespace=indent trail ..whatever other stuff.." is already a non-starter. In the example in the message you are responding to, I want to find paths whose "whitespace" attribute is set to the exact string "indent,trail,space". And I do not want the pathspec magic code to know how the interpretation of "whitespace" attribute treats comma in the string. It may or may not have any special meaning, so if you meant "whitespace=indent trail ..whatever other stuff.." to mean "either whitespace is set to indent, or whitespace is set to trail", then that is already unacceptable.