git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Segfault in the attr stack

From
Duy Nguyen <pclouds@gmail.com>
Date
Jun 2, 2016, 01:02 UTC
Message-ID
<CACsJy8A4gXRyx4LpBmM2Y=n2KB0NurKMiW42-tPnU7K89qj5bw@mail.gmail.com>
In-Reply-To
<CAPc5daXuQAeWvJAciRA_Kzyoxa=atEntGzKhqzjiN+ho6TnQyg@mail.gmail.com>
On Thu, Jun 2, 2016 at 5:17 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 6 quoted lines
> Gaah, of course.
>
> This is coming from the cache preload codepath, where multiple threads
> try to run ce_path_match().
> It used to be OK because pathspec magic never looked at attributes,
> but now it does, and attribute system is not thread-safe.

Off topic. I wonder if we can annotate which functions are thread-safe (minority currently in git code base, I believe) and make gcc, clang or sparse spot them in threaded code?

-- 
Duy
Previous: Stefan BellerNext: Duy Nguyen
Message 11 of 12 in “Segfault in the attr stack”
  1. Stefan BellerJun 1, 2016
  2. Junio C HamanoJun 1, 2016
  3. Stefan BellerJun 1, 2016
  4. Junio C HamanoJun 1, 2016
  5. Stefan BellerJun 1, 2016
  6. Junio C HamanoJun 1, 2016
  7. Junio C HamanoJun 1, 2016
  8. Junio C HamanoJun 2, 2016
  9. Junio C HamanoJun 2, 2016
  10. Stefan BellerJun 2, 2016
  11. Duy NguyenJun 2, 2016
  12. Duy NguyenJun 2, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.