git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 0/5] Add --format to tag verification

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 30, 2016, 23:28 UTC
Message-ID
<xmqqlgy97ys0.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<20160930221806.3398-1-santiago@nyu.edu>

What is in the patch series looked more or less good to me. Lukas's sirname was still P in [3/5], a patch in [4/5] added an unnecssary blank line before git_verify_tag_config() and also a local variable declaration for "char *fmt_pretty" was indented funnily, but none of these were something I couldn't fix up locally.

I however notice that there is no new tests to protect these two new features from future breakages. Perhaps you want to add some in [6/5]?

Thanks.
Previous: santiago@nyu.eduNext: Santiago Torres
Message 9 of 11 in “Add --format to tag verification”
  1. 0/5 Add --format to tag verificationsantiago@nyu.edu, Sep 30, 2016
  2. 1/5 gpg-interface, tag: add GPG_VERIFY_QUIET flagsantiago@nyu.edu, Sep 30, 2016
  3. 2/5 ref-filter: add function to print single ref_array_itemsantiago@nyu.edu, Sep 30, 2016
  4. Jakub NarębskiSep 30, 2016
  5. Junio C HamanoOct 1, 2016
  6. 3/5 tag: add format specifier to gpg_verify_tagsantiago@nyu.edu, Sep 30, 2016
  7. 5/5 builtin/tag: add --format argument for tag -vsantiago@nyu.edu, Sep 30, 2016
  8. 4/5 builtin/verify-tag: add --format to verify-tagsantiago@nyu.edu, Sep 30, 2016
  9. Junio C HamanoSep 30, 2016
  10. Santiago TorresOct 3, 2016
  11. Junio C HamanoOct 3, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.