From: Junio C Hamano Date: Fri, 30 Sep 2016 23:28:47 GMT Subject: Re: [PATCH v3 0/5] Add --format to tag verification Message-ID: In-Reply-To: <20160930221806.3398-1-santiago@nyu.edu> What is in the patch series looked more or less good to me. Lukas's sirname was still P in [3/5], a patch in [4/5] added an unnecssary blank line before git_verify_tag_config() and also a local variable declaration for "char *fmt_pretty" was indented funnily, but none of these were something I couldn't fix up locally. I however notice that there is no new tests to protect these two new features from future breakages. Perhaps you want to add some in [6/5]? Thanks.