Re: [PATCH v3 3/3] read-cache: make sure file handles are not inherited by child processes
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 25, 2016, 22:54 UTC
- Message-ID
- <xmqqlgxcm43o.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <20161025213318.GB8683@starla>
Eric Wong <e@80x24.org> writes:
> But I have a _slight_ preference towards Dscho's version in > <alpine.DEB.2.20.1610251230150.3264@virtualbox> in case we > decide to start using another O_* flag in here.
Interesting. The reason why I have a slight preferene to separate the fixed part and the toggle-able part is exactly because I want the code to be prepared in case we decide to start using other O_* flags in the future.
I guess different people have different tastes, as usual ;-)