From: Junio C Hamano Date: Tue, 25 Oct 2016 22:54:51 GMT Subject: Re: [PATCH v3 3/3] read-cache: make sure file handles are not inherited by child processes Message-ID: In-Reply-To: <20161025213318.GB8683@starla> Eric Wong writes: > But I have a _slight_ preference towards Dscho's version in > in case we > decide to start using another O_* flag in here. Interesting. The reason why I have a slight preferene to separate the fixed part and the toggle-able part is exactly because I want the code to be prepared in case we decide to start using other O_* flags in the future. I guess different people have different tastes, as usual ;-)