Re: [RFCv4 PATCH 00/14] Checkout aware of Submodules!
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 16, 2017, 22:00 UTC
- Message-ID
- <xmqqlgt5vlse.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <20170216003811.18273-1-sbeller@google.com>
Stefan Beller <sbeller@google.com> writes:
> Integrate updating the submodules into git checkout,...
It was more or less a pleasant read, once I decided to pretend that I were a machine who uses identifiers only to identify locations in the program ;-) IOW, for human consumption, the new names introduced were sometimes quite confusing and went against helping understanding.
I saw a few places where logic looked somewhat iffy, which I sent separate comments on; I may spot more if the code used more understandable names and calling conventions, but that is OK. It is an expected part of an iterative process.
I can feel that this topic is getting closer to where we eventually want to go.
Thanks.