Re: [PATCH 15/15] builtin/checkout: add --recurse-submodules switch

From: Stefan Beller <sbeller@google.com>
Date: Feb 24, 2017, 19:20 UTC
Message-ID: <CAGZ79kbD8SBHURQJvrNKKP8Ycay8wZcwUGw7V4mmo6PmfmJ9=w@mail.gmail.com>
In-Reply-To: <db5cfde2-a769-d786-8846-a5a526194b69@ramsayjones.plus.com>

On Thu, Feb 23, 2017 at 5:25 PM, Ramsay Jones <ramsay@ramsayjones.plus.com> wrote:

Show 7 quoted lines

>> +int option_parse_recurse_submodules(const struct option *opt,
>> +                                 const char *arg, int unset)
>
> Again, this function should be marked static.
>
> [I also noted _two_ other local functions with the same name
> in builtin/fetch.c and builtin/push.c]

fixed in a reroll.

Yes there is a pattern here. But as both fetch and push accept different options (not just boolean, but strings) these have to be different. I thought about unifying them, but I do not think we can do so easily.

Thanks, Stefan

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.