git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] [GSOC] show_bisect_vars(): Use unsigned int instead of signed int for flags

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 2, 2017, 03:30 UTC
Message-ID
<xmqqlgrjtrjl.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<CAJYcaSNAB+1gth2NkTjrcBV9TXT9bRsBQhwOsQCmnudYz5bTmg@mail.gmail.com>
Robert Stanca <robert.stanca7@gmail.com> writes:
> I am used to 1change per patch so it's easier  to redo specific
> patches...if there are small changes(10 lines max) can i send them as
> 1 patch?

It's not number of lines. One line per patch does not make sense if you need to make corresponding changes to two places, one line each, in order to make the end result consistent. If you change a type of a structure field, and that field is assigned to a variable somewhere, you would change the type of both that field and the variable that receives its value at the same time in a single commit, as that would be the logical unit of a smallest change that still makes sense (i.e. either half of that change alone would not make sense).

Previous: Robert StancaNext: Robert Stanca
Message 5 of 9 in “[GSOC] Convert signed flags to unsigned”
  1. 1/2 [GSOC] Convert signed flags to unsignedRobert Stanca, Apr 1, 2017
  2. 2/2 [GSOC] show_bisect_vars(): Use unsigned int instead of signed int for flagsRobert Stanca, Apr 1, 2017
  3. Junio C HamanoApr 1, 2017
  4. Robert StancaApr 1, 2017
  5. Junio C HamanoApr 2, 2017
  6. Robert StancaApr 2, 2017
  7. Junio C HamanoApr 2, 2017
  8. Junio C HamanoApr 1, 2017
  9. Robert StancaApr 1, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.