git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/2] [GSOC] Convert signed flags to unsigned

From
RSRobert Stanca <robert.stanca7@gmail.com>
Date
Apr 1, 2017, 15:30 UTC
Message-ID
<20170401153049.21400-1-robert.stanca7@gmail.com>
 Unsigned int is a closer representation of bitflags rather than signed int that uses 1 special bit for sign.This shouldn't make much difference because rev_list_info.flags uses only 2 bits(BISECT_SHOW_ALL and REV_LIST_QUIET)
Signed-off-by: Robert Stanca <robert.stanca7@gmail.com>
---
 bisect.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/bisect.h b/bisect.h
index acd12ef80..a979a7f11 100644
--- a/bisect.h
+++ b/bisect.h
@@ -16,7 +16,7 @@ extern struct commit_list *filter_skipped(struct commit_list *list,
 
 struct rev_list_info {
 	struct rev_info *revs;
-	int flags;
+	unsigned int flags;
 	int show_timestamp;
 	int hdr_termination;
 	const char *header_prefix;
-- 
2.12.2.575.gb14f27f91.dirty
Next: Robert Stanca
Message 1 of 9 in “[GSOC] Convert signed flags to unsigned”
  1. 1/2 [GSOC] Convert signed flags to unsignedRobert Stanca, Apr 1, 2017
  2. 2/2 [GSOC] show_bisect_vars(): Use unsigned int instead of signed int for flagsRobert Stanca, Apr 1, 2017
  3. Junio C HamanoApr 1, 2017
  4. Robert StancaApr 1, 2017
  5. Junio C HamanoApr 2, 2017
  6. Robert StancaApr 2, 2017
  7. Junio C HamanoApr 2, 2017
  8. Junio C HamanoApr 1, 2017
  9. Robert StancaApr 1, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.