Re: [PATCH] test: remove unused parameter from the wildmatch test

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 26, 2017, 04:02 UTC
Message-ID: <xmqqlgqnstod.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CACBZZX7x0hSy5PTCo1Cf0Hp09jBhnSF0T=BseH68kwMRmqGJig@mail.gmail.com>

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

Show 9 quoted lines

> Right now this is all dead code, but I wonder if instead we should be
> partially reverting commit 70a8fc999d ("stop using fnmatch (either
> native or compat)", 2014-02-15) by Duy to the extent of being able to
> extend t/helper/test-wildmatch.c to test fnmatch() as well.
>
> We wouldn't be using fnmatch(), but I think it's a probably a good
> idea for the tests to support a mode where we have to declare
> explicitly whether something should also match under fnmatch or not,
> so we document the differences.

I am on the fence and can go either way. What you suggest is intellectually intriguing even though I am unsure of its practical value.