Re: [PATCH] test: remove unused parameter from the wildmatch test

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Apr 25, 2017, 09:51 UTC
Message-ID: <CACBZZX7x0hSy5PTCo1Cf0Hp09jBhnSF0T=BseH68kwMRmqGJig@mail.gmail.com>
In-Reply-To: <20170425094453.9823-1-avarab@gmail.com>

On Tue, Apr 25, 2017 at 11:44 AM, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

Show 13 quoted lines

> Remove the unused second parameter to the match() function. Since
> commit 70a8fc999d ("stop using fnmatch (either native or compat)",
> 2014-02-15) this hasn't been used, but was previously used to indicate
> ok/fail if the fnmatch() backend was in use.
>
> The "x" argument meant that the test would be skipped for
> fnmatch(). Support for that was implicitly added in commit
> feabcc173b ("Integrate wildmatch to git", 2012-10-15) by leaving out
> an "else" condition, and made use of starting in commit
> b79c0c3755 ("wildmatch: properly fold case everywhere", 2013-05-30).
>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---

Right now this is all dead code, but I wonder if instead we should be partially reverting commit 70a8fc999d ("stop using fnmatch (either native or compat)", 2014-02-15) by Duy to the extent of being able to extend t/helper/test-wildmatch.c to test fnmatch() as well.

We wouldn't be using fnmatch(), but I think it's a probably a good idea for the tests to support a mode where we have to declare explicitly whether something should also match under fnmatch or not, so we document the differences.