git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] sequencer: mark a file local symbol as static

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 23, 2018, 18:22 UTC
Message-ID
<xmqqlggoigee.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<43b60294-0e8f-0f6e-1b9a-8a2779777513@ramsayjones.plus.com>
Ramsay Jones <ramsay@ramsayjones.plus.com> writes:
Show 10 quoted lines
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>
> Hi Phillip,
>
> If you need to re-roll your 'pw/sequencer-in-process-commit' branch, could
> you please squash this into the relevant patch (commit da96adcf5a,
> "sequencer: run 'prepare-commit-msg' hook", 2018-01-19).
>
> Thanks.

Thanks; as the commit is sitting at the tip of the topic not yet in 'next', let me just squash it in.

Show 20 quoted lines
>
> ATB,
> Ramsay Jones
>
>  sequencer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sequencer.c b/sequencer.c
> index 79579ba11..5bfdc4044 100644
> --- a/sequencer.c
> +++ b/sequencer.c
> @@ -893,7 +893,7 @@ void commit_post_rewrite(const struct commit *old_head,
>  	run_rewrite_hook(&old_head->object.oid, new_head);
>  }
>  
> -int run_prepare_commit_msg_hook(struct strbuf *msg, const char *commit)
> +static int run_prepare_commit_msg_hook(struct strbuf *msg, const char *commit)
>  {
>  	struct argv_array hook_env = ARGV_ARRAY_INIT;
>  	int ret;
Previous: Ramsay Jones
Message 2 of 2 in “sequencer: mark a file local symbol as static”
  1. sequencer: mark a file local symbol as staticRamsay Jones, Jan 22, 2018
  2. Junio C HamanoJan 23, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.