threads / patch / 47662

patchsequencer: mark a file local symbol as static

Subject: [PATCH] sequencer: mark a file local symbol as static

## tl;dr

2 messages between Jan 22, 2018 and Jan 23, 2018. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Ramsay Jones· Jan 22, 2018, 00:30 UTC · lore

Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---

Hi Phillip,

If you need to re-roll your 'pw/sequencer-in-process-commit' branch, could you please squash this into the relevant patch (commit da96adcf5a, "sequencer: run 'prepare-commit-msg' hook", 2018-01-19).

Thanks.

ATB, Ramsay Jones

 sequencer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Show changes to sequencer.c +1 −1

diff --git a/sequencer.c b/sequencer.c
index 79579ba11..5bfdc4044 100644
--- a/sequencer.c
+++ b/sequencer.c
@@ -893,7 +893,7 @@ void commit_post_rewrite(const struct commit *old_head,
 	run_rewrite_hook(&old_head->object.oid, new_head);
 }
 
-int run_prepare_commit_msg_hook(struct strbuf *msg, const char *commit)
+static int run_prepare_commit_msg_hook(struct strbuf *msg, const char *commit)
 {
 	struct argv_array hook_env = ARGV_ARRAY_INIT;
 	int ret;

-- 
2.16.0

Junio C Hamano· Jan 23, 2018, 18:22 UTC · re: Ramsay Jones · lore

Re: [PATCH] sequencer: mark a file local symbol as static

Ramsay Jones <ramsay@ramsayjones.plus.com> writes:

Show 10 quoted lines

> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>
> Hi Phillip,
>
> If you need to re-roll your 'pw/sequencer-in-process-commit' branch, could
> you please squash this into the relevant patch (commit da96adcf5a,
> "sequencer: run 'prepare-commit-msg' hook", 2018-01-19).
>
> Thanks.

Thanks; as the commit is sitting at the tip of the topic not yet in 'next', let me just squash it in.

Show 20 quoted lines

>
> ATB,
> Ramsay Jones
>
>  sequencer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sequencer.c b/sequencer.c
> index 79579ba11..5bfdc4044 100644
> --- a/sequencer.c
> +++ b/sequencer.c
> @@ -893,7 +893,7 @@ void commit_post_rewrite(const struct commit *old_head,
>  	run_rewrite_hook(&old_head->object.oid, new_head);
>  }
>  
> -int run_prepare_commit_msg_hook(struct strbuf *msg, const char *commit)
> +static int run_prepare_commit_msg_hook(struct strbuf *msg, const char *commit)
>  {
>  	struct argv_array hook_env = ARGV_ARRAY_INIT;
>  	int ret;